nunnatsa / ginkgolinter

golang linter for ginkgo and gomega
MIT License
25 stars 6 forks source link

Fix issue: panic when using custom matchers #126

Closed nunnatsa closed 9 months ago

nunnatsa commented 9 months ago

Description

custom matchers that are defined in other packages, and get no parameters, cause panic, ans they wrongly treated as the MatchError matcher.

Custom matchers that are defined in other packages, and get some parameters, may cause false positive for wrong usage of MatchError matcher.

This PR fixes this issue.

Fixes #124

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

@nunnatsa

github-actions[bot] commented 9 months ago

Pull Request Test Coverage Report for Build 7272279591


Changes Missing Coverage Covered Lines Changed/Added Lines %
ginkgo_linter.go 19 21 90.48%
<!-- Total: 19 21 90.48% -->
Totals Coverage Status
Change from base Build 7244526420: 0.3%
Covered Lines: 1109
Relevant Lines: 1308

💛 - Coveralls