New Rule: Avoid spec Pollution

[nunnatsa]

Description

Does not allow variable assignments in container nodes. See here for more details: https://onsi.github.io/ginkgo/#avoid-spec-pollution-dont-initialize-variables-in-container-nodes

This rule is disabled by default. use the --forbid-spec-pollution=true flag to enable it.

For example, this code will trigger a warning:

var _ = Describe("description", func(){
    var x = 10
    ...
})

Instead, use BeforeEach(); e.g.

var _ = Describe("description", func (){
    var x int

    BeforeEach(func (){
        x = 10
    })
    ...
})

Closes: #136

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [x] This change requires a documentation update

How Has This Been Tested?

• [x] Added test case and related test data
• [x] Update the functional test

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I ran golangci-lint

[coveralls]

Pull Request Test Coverage Report for Build 8324983153

Details

• 2 of 22 (9.09%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-3.2%) to 63.95%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/ginkgohandler/handler.go	0	20	0.0%
<!--	Total:	2	22	9.09%	-->

Files with Coverage Reduction	New Missed Lines	%
internal/ginkgohandler/handler.go	1	47.46%
<!--	Total:	1		-->

Totals
Change from base Build 8321952766:	-3.2%
Covered Lines:	204
Relevant Lines:	319

---

💛 - Coveralls