nunnatsa / ginkgolinter

golang linter for ginkgo and gomega
MIT License
24 stars 6 forks source link

Bug fix: missing async wrong error checks #146

Closed nunnatsa closed 3 months ago

nunnatsa commented 3 months ago

Description

the linter didn't check error with nil assertion also in async assertions, such as:

Eventually(func() err {return nil}).Should(BeNil())

Also, the linter didn't check for MatchError issues in async assertions, e.g.

Eventually(func() string {return "hello"}).Should(MatchError("hello"))

This PR adds these chacks.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 8512491892

Details


Totals Coverage Status
Change from base Build 8408249096: 0.0%
Covered Lines: 208
Relevant Lines: 323

💛 - Coveralls