Closed nunnatsa closed 2 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
ginkgo_linter.go | 149 | 167 | 89.22% | ||
types/suppress.go | 10 | 34 | 29.41% | ||
<!-- | Total: | 213 | 255 | 83.53% | --> |
Totals | |
---|---|
Change from base Build 2684578225: | -0.1% |
Covered Lines: | 466 |
Relevant Lines: | 538 |
Check these patterns:
Expect(err).To(Equal(nil))
Expect(err).To(BeNil())
Expect(err == nil).To(BeTrue/BeFalse())
Expect(err == nil).To(Equal(true/false))
Support new suppress comment:
ginkgo-linter:ignore-err-assert-warning
Support new parameter:
--suppress-err-assertion
Also, added more nil check:
Expect(x).To(Equal(nil))
Refactoring: move many things to new packages to reduce the code size in ginkgo_linter.go and make it more readable.