nunnatsa / ginkgolinter

golang linter for ginkgo and gomega

MIT License

26 stars 6 forks source link

bug fix: false negative when comparing a pointer and an interface #79

Closed nunnatsa closed 1 year ago

nunnatsa commented 1 year ago

Description

For example, the function f()'s returned type is an interfce, but it actually returns a pointer.

The linter triggered a warning for this code:

Expect(somePointer).Eqaul(f())

But this is a actually a valid assertion.

This PR fixes this bug and does not trigger the warning the assertion compares to types.Named.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Added test case and related test data
[x] Update the functional test

Checklist:

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I ran golangci-lint

@nunnatsa

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4588212579

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 84.293%

Totals
Change from base Build 4587746892:	0.1%
Covered Lines:	805
Relevant Lines:	955

💛 - Coveralls