New Rule: Missing Assertion Method

[nunnatsa]

Description

The linter warns when calling an "actual" method (e.g. Expect(), Eventually() etc.), without an assertion method (e.g Should(), NotTo() etc.)

For example:

// no assertion for the result
Eventually(doSomething).WithTimeout(time.Seconds * 5).WithPolling(time.Milliseconds * 100)

The linter will not suggest a fix for this warning.

This rule cannot be suppressed.

Type of change

Please delete options that are not relevant.

• [x] New feature (non-breaking change which adds functionality)
• [x] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [x] Added test case and related test data
• [X] Update the functional test

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] I ran golangci-lint

[github-actions[bot]]

Pull Request Test Coverage Report for Build 4906458581

• 42 of 47 (89.36%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 84.592%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
gomegahandler/handler.go	10	15	66.67%
<!--	Total:	42	47	89.36%	-->

Totals
Change from base Build 4830797408:	0.2%
Covered Lines:	840
Relevant Lines:	993

---

💛 - Coveralls