nunnatsa / ginkgolinter

golang linter for ginkgo and gomega
MIT License
24 stars 6 forks source link

Fix bug: false positive warning for typed function calls #92

Closed nunnatsa closed 1 year ago

nunnatsa commented 1 year ago

Description

When calling a function that return a type in the async assertion (eventually/constantly) body, if this type is a function, the linter fails to recognize it and fire a warning.

This PR fixes this bug, by checking the underline types.

Fixes #91

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

@nunnatsa

nunnatsa commented 1 year ago

@pohly, would you mind to take a look at this fix?

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5391259784


Totals Coverage Status
Change from base Build 5391215987: 0.08%
Covered Lines: 845
Relevant Lines: 998

💛 - Coveralls