search

nuno / TiCollectionView

UICollectionView / GridView for Appcelerator Titanium
MIT License
111 stars 43 forks source link

Run on main thread need to be implemented #59

Closed nuno closed 7 years ago

nuno commented 8 years ago

If we use true in tiapp.xml the module unfortunately it does not work. @mpociot @viezel @adesugbaa Any help is appreciated!

AppWerft commented 8 years ago

OK, it is possible to realize. Look to my tutorial. https://github.com/AppWerft/TitaniumAndroidModuleDevelopment/blob/master/04-WaterWaveProgress.md

hansemannn commented 8 years ago

I'll take a look 😉

nuno commented 8 years ago

@hansemannn You the man!

hansemannn commented 8 years ago

Basically what you guys need is to use ENSURE_UI_THREAD in some places for the correct threading behavior, especially for UI-related manipulations. And you use some mutex locks (pthread_mutex) that can cause problems across some places when running on main thread.

You can search the Titanium Core for ENSURE_UI_THREAD and TI_USE_KROLL_THREAD to see where and how we use those. Not sure when I will find time for a closer look, so this should guide you in the correct direction.

nuno commented 8 years ago

Thank you for your time @hansemannn !

hansemannn commented 7 years ago

Will look into it this week. What else are critical iOS issues in here? A prioritized list would be cool. Thanks!

EDIT: Playing around in https://github.com/nuno/TiCollectionView/pull/66

nuno commented 7 years ago

I Have a few things yeah. I will put in list. One think I want this module be able to do is change the layout on the fly, ex, like pinterest

You have list of grid-layout, then you click one grid and change to horizontal-layout (kinda of scrollableView) that you can swipe to one by one item.

Now this layout config is manually and is I think on creation only.

hansemannn commented 7 years ago

The example works using #66, please try it out!