✨ Add `linksColor` (and presets) to the `alert` shortcode

nunocoracao / blowfish

Personal Website & Blog Theme for Hugo

https://blowfish.page

MIT License

1.24k stars 360 forks source link

✨ Add `linksColor` (and presets) to the `alert` shortcode #1429

Open Usual-Coder opened 2 months ago

Usual-Coder commented 2 months ago

Limitation

While customizing alert colors is a neat feature, not being able to change links color can make them hard to read 🤷

Proposed solution

Add a parameter named linksColor to allow that customization?!

Thanks for considering that enhancement 🙇

Usual-Coder commented 2 months ago

May I also suggest presets, to mimic alerts Markdown extension (full support for that extension may require way more work than just providing presets to mimic them ... since your alert shortcode is so close to being able to provide that feature 🤔 ... just my 2 cents 🤷)

Usual-Coder commented 2 months ago

And since we're talking about alert, may I also suggest:

adding a small padding (top + bottom) ... so things like the badges could be nicely placed (before/after) without being sticked to that alert (or creating a spacer shortcode to handle that behavior ... and avoid the trickery required otherwise 🤐😅)
allowing remote URL for the icon
allowing an emoji instead of the icon

As always, those suggestions are made with utterly great respect for your own priorities 🙇

Usual-Coder commented 2 months ago

Hi, you have a question ?

nunocoracao commented 2 months ago

@Usual-Coder No

Usual-Coder commented 2 months ago

I was asking because of your question label (still visible). But since everything seems ok on your side. Have a nice day 😅 And once again thanks for everything 🙇

nunocoracao commented 1 month ago

Sorry @Usual-Coder been busy... the question tag is for me to think when/if I can invest time on this one. Happy to review a PR though