search

nunocoracao / blowfish

Personal Website & Blog Theme for Hugo
https://blowfish.page
MIT License
1.53k stars 420 forks source link

Change title to fix folder name for Windows user #1839

Open michaeldorner opened 1 week ago

michaeldorner commented 1 week ago

This PR fixes the issue for Windows users introduced in #1780 by a title that contains : (thanks @eallion for the hint!)

eallion commented 1 week ago

😊

unacro commented 1 week ago

And it's the right way for fix #1835.

Good job. Hope to merge it ASAP.

deining commented 1 week ago

And it's the right way for fix #1835.

I agree.

However, this PR does not fully resolve #1835. Even with this PR in place, you get an error when using this theme as go/hugo module:

go get github.com/michaeldorner/blowfish/v2@8f6778d80d0055e9d2070d1e7085d035dd8c453d
go: downloading github.com/michaeldorner/blowfish/v2 v2.0.0-20241109090851-8f6778d80d00
go: github.com/michaeldorner/blowfish/v2@8f6778d80d0055e9d2070d1e7085d035dd8c453d: create zip: exampleSite/content/users/Xeonzilla’s Note/feature.jpg: malformed file path "exampleSite/content/users/Xeonzilla’s Note/feature.jpg": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.it.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.it.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.ja.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.ja.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.md": invalid char '’'
exampleSite/content/users/Xeonzilla’s Note/index.zh-cn.md: malformed file path "exampleSite/content/users/Xeonzilla’s Note/index.zh-cn.md": invalid char '’'

This is due to the use of ’ in a directory name.

michaeldorner commented 1 week ago

Darn, sorry for the sloppy work. I fixed it.

Since we partially use already domains as folder names, may I suggest to consistently roll out this naming convention to avoid this problem in the future?

unacro commented 1 week ago

Darn, sorry for the sloppy work. I fixed it.

Since we partially use already domains as folder names, may I suggest to consistently roll out this naming convention to avoid this problem in the future?

Can't agree more. Similar situations is as hell