search

nunofgs / docker-octoprint

Dockerfile to set up Octoprint with x86, armv6, armv7 and arm64 support!
https://hub.docker.com/r/nunofgs/octoprint/
GNU Affero General Public License v3.0
58 stars 32 forks source link

Add plugins bin to PATH #40

Open danielmoore opened 4 years ago

danielmoore commented 4 years ago

Some Octoprint plugins require /data/plugins/bin to be on the PATH, otherwise installation will fail.

In particular, I was unable to update DisplayLayerProgress because markdown_py wasn't on the PATH. This fixed it.

LongLiveCHIEF commented 4 years ago

:wave: @danielmoore. I'm the maintainer of the official octoprint/octoprint image. @nunofgs and I have been working together to migrate this image's capabilities and functionality into the official image.

I'm considering adding this PR to the image, but I'm checking on some official octoprint settings first, in order to ensure this doesn't open up security loopholes.

Since this is your request, would you mind opening this as a feature request to https://github.com/OctoPrint/octoprint-docker/issues?

LongLiveCHIEF commented 4 years ago

Actually, after digging a bit, we're going to leave this out. This is not something that Octoprint designs as a standard thing available to plugin authors, so it would be something you would need to add to your own implementation rather than adding it to everyone's implementation.

danielmoore commented 4 years ago

Gotcha. I'd rather stick to the blessed image than hack this solution in long-term. Do you have any ideas on how to install a plugin like DisplayLayerProgress? Or is this just an issue for the plugin author?

LongLiveCHIEF commented 4 years ago

out plugin maintainers group took a look at that plugin, and they couldn't see any reason why that folder would need to be added to PATH. Regardless, if a plugin needs modification of the host system, then you'll need to be responsible for making that same modification to your specific container, or create your own image from our image that you can use to create a container.