search

nunomaduro / collision

💥 Collision is a beautiful error reporting tool for command-line applications
https://nunomaduro.com
MIT License
4.49k stars 156 forks source link

Do not suppress warning messages #294

Open selfsimilar opened 10 months ago

selfsimilar commented 10 months ago

This is a fix for #293. Warnings should not be suppressed, unless you also suppress the output on STDERR.

tuytoosh commented 9 months ago

I'm working on a codebase with tons of tests, and my pipeline was consistently failing with a 1 exit code, without any error or warning. After a couple of days of debugging, I realized the issue: "A test file without implementation".

I'm not sure why this piece of code was being suppressed, but it should be fixed.

edh649 commented 4 months ago

I would also like to see this merged, it's affected by CI pipeline too and makes it very difficult to work out why CI is failing despite all tests passing.

yuraplohov commented 2 months ago

I am also waiting for this fix. I'm facing the same problem with CI piplene that falls without errors. And it also took a while to figure out the reason. The warning "No tests found in class" should not be suppressed. Until this is fixed, I have to use kludges.

jaymoh commented 1 month ago

I would also like to see this merged. I'm aware the contributors have a lot of work, so I will be refreshing this page every week, to monitor progress.

Ghustavh97 commented 1 month ago

Any updates on this PR? I think suppressing messages that generate an exit code greater than 0 is not a good idea.