Allow to customize loading text

nunomaduro / laravel-console-task

✅ Laravel Console Task is a output method for Laravel Console Commands.

MIT License

254 stars 21 forks source link

Allow to customize loading text #7

Closed miclf closed 5 years ago

miclf commented 5 years ago

loading... is not always the most appropriate verb for a task that is running. Depending on the context, a command might be generating something, connecting to some remote server, downloading a file, etc.

So I thought it could be nice to be able to customize this hardcoded string.

To avoid any breaking change, this pull request simply adds an argument at the end of the method signature, which gives us the following usage:

$this->task('Foo', $callable, 'uploading...');

nunomaduro commented 5 years ago

Thanks for this!

nunomaduro commented 5 years ago

@miclf Can you please add something to the docs and some tests?

miclf commented 5 years ago

@nunomaduro Sorry for replying late, I’ve been quite busy these days.

I will try something for docs and tests once I get some time :)