nunomaduro / phpinsights

🔰 Instant PHP quality checks from your console
https://phpinsights.com
MIT License
5.28k stars 280 forks source link

Collision between Line Length vs 0 lines between same types #514

Open djallits opened 3 years ago

djallits commented 3 years ago
Q A
Bug report? yes
Feature request? no
Library version 2.0.0
use Illuminate\Cache\RateLimiting\Limit;
use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;
use Illuminate\Http\Request;

Generates Line exceeds 80 characters; contains 84 characters

use Illuminate\Cache\RateLimiting\Limit;
use Illuminate\Foundation\Support\Providers\RouteServiceProvider
    as ServiceProvider;
use Illuminate\Http\Request;

Generates Expected 0 lines between same types of use statement, found 1.

Simple solution would be to not sniff use statements for line length.

djallits commented 3 years ago

Should also mention that the following is valid. Note there is a line break with the last use statement, but no following use statements.

use Illuminate\Auth\Events\Registered;
use Illuminate\Auth\Listeners\SendEmailVerificationNotification;
use Illuminate\Foundation\Support\Providers\EventServiceProvider
    as ServiceProvider;
djallits commented 5 months ago

This has gone stale.