search

nunomaduro / phpinsights

🔰 Instant PHP quality checks from your console
https://phpinsights.com
MIT License
5.28k stars 281 forks source link

Fix non-existing default property #652

Closed hdcore closed 1 year ago

hdcore commented 1 year ago
Q A
Bug fix? yes
New feature? no
Fixed tickets

Removing the default for a non-existing property newlinesCountBetweenOpenTagAndDeclare in DeclareStrictTypesSniff (https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Sniffs/TypeHints/DeclareStrictTypesSniff.php) that gives an deprecation notice in PHP 8.2.

cmgmyr commented 1 year ago

Thanks! Looks like the method was renamed in this commit

hdcore commented 11 months ago

It looks you've added the old variable name "newlinesCountBeforeDeclare" instead of the current one "linesCountBeforeDeclare". https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Sniffs/TypeHints/DeclareStrictTypesSniff.php