nunomaduro / phpinsights

🔰 Instant PHP quality checks from your console
https://phpinsights.com
MIT License
5.32k stars 283 forks source link

Unused package justinrainbow/json-schema #688

Open DannyvdSluijs opened 4 months ago

DannyvdSluijs commented 4 months ago
Q A
Bug report? no
Feature request? no
Library version master

As a maintainer of json-schema I was looking at our top dependent libraries in order to do some smoke testing for the upcoming v6 release. I was surprised to see there was no code related to json-schema in this repo although it being on of the top dependants (No.3 if you count by number of ⭐ ).

Timeline

🔍 After some puzzling I found the following timeline and reason why we are still left with json-schema as a dependency.

Current output on my fork of master

$ composer why justinrainbow/json-schema
nunomaduro/phpinsights dev-master requires justinrainbow/json-schema (^5.2.13)

$ git rev-parse --short HEAD 
f476219

Why no PR?

At this time I don't have the time to draft a PR but rather took the time to create a decent report making this for a "Good first issue"

Jibbarth commented 1 month ago

Thanks, I will handle it :slightly_smiling_face: