Closed fabio-ivona closed 1 year ago
Will check in a while the failing test
@xiCO2k would you mind to try executing tests in your local environment? I don't see them fail on my machine, I'm wondering if it is a workflows environment issue
All passing local as well.
That's weird, maybe this fails in workflows because it detects there's not interactive terminal?
Definately possible, we may need to check on Symfony Console source how they test that stuff.
Definately possible, we may need to check on Symfony Console source how they test that stuff.
They gave up too :rofl:
I updated the test adding a skip if stty
is not available and added a test to ensure autocomplete values are set in Symfony Question
ping @nunomaduro
@nunomaduro can we merge this PR, please?
@xiCO2k I updated the code merging from #156
I guess that switching from
return $output->ask($html);
to
return $output->askQuestion($question);
should solve the conflict, but it would be great if you could have a look at it too
@xiCO2k I updated the code merging from https://github.com/nunomaduro/termwind/pull/156
I guess that switching from
return $output->ask($html); to
return $output->askQuestion($question); should solve the conflict, but it would be great if you could have a look at it too
Will check @fabio-ivona
@xiCO2k phpstan errors fixed in #158
Thanks
Looks good to me, @nunomaduro thoughts?
This PR will add autocomplete feature for ask/Question
here's the resulting prompt:
https://user-images.githubusercontent.com/8792274/188404964-8d521a32-3a3d-4a7d-8e54-2e99d5c886da.mp4