search

nunomaduro / termwind

🍃 In short, it's like Tailwind CSS, but for the PHP command-line applications.
MIT License
2.29k stars 78 forks source link

Add support for borders #178

Open caendesilva opened 1 year ago

caendesilva commented 1 year ago

Hey! Here's my initial work on border support (fixing https://github.com/nunomaduro/termwind/issues/177)

I've created the base logic, and think that it would be best if I could get some maintainer help to make sure it gets fully integrated with how the rest of the Termwind framework is supposed to work.

I think since the rendering logic is kinda complex it could make sense to have this as a pseudo-element rather than a style, but that's something that's up to you. I put the heavy logic in an action class to make it more self-contained depending on how you want to handle it. I have not yet added support for colours as I just want to know if I'm on the right track first.

xiCO2k commented 10 months ago

Hey @caendesilva thanks for the PR.

I would say we need to have the same api, with the rounded border border-{color}` and I would not have the padding by default.

Can you make this adjustments?

Thanks and sorry for the delay reviewing your PR.

caendesilva commented 10 months ago

Hey @caendesilva thanks for the PR.

I would say we need to have the same api, with the rounded border border-{color}` and I would not have the padding by default.

Can you make this adjustments?

Thanks and sorry for the delay reviewing your PR.

Hey! I'll try, I need to learn more about how the other components work so may take some time

xiCO2k commented 10 months ago

no worries, any question let me know.

Thanks, Francisco.