Closed xiCO2k closed 3 years ago
Coverage is failing, can you check?
Yes to not remove the options completely since there may be cases that we will use it, added the coverage ignore for that.
// @codeCoverageIgnoreStart
foreach ($this->properties['options'] as $option) {
$options[] = $option;
}
// @codeCoverageIgnoreEnd
if you want to remove it completely let me know.
If we are not using them, remove it.
Got it.
This PR breaks methods which modify the content, e.g.: truncate, uppercase, capitalize, snakecase, because the options are now hardcoded into the content.
E.g. <div class="font-bold uppercase">text</div>
renders <bg=default;options=>\e[1MTEXT\e[0M</>
.
@sebdesign Thanks for catching it.
We have other ones like invisible
, line-through
that will have the same problem with text mutation.
Can you create an issue with that information?
Thanks.
To avoid interfering with the
prepend()
, changed the classesfont-bold
andunderline
Code
Before
After