search

nununoisy / gb-presenter-rs

GBS/LSDj visualizer based on SameBoy and FFmpeg
MIT License
59 stars 1 forks source link

Noise register values should be reversed #6

Closed defensem3ch closed 1 year ago

defensem3ch commented 1 year ago

Lower noise values should happen on the left and higher noise values should happen on the right, reverse of what it is now. This would match the rest of the notes/pitches on the keyboard.

nununoisy commented 1 year ago

The current solution for mapping the noise channel to the piano roll is a bit of a hack. I want to fix it for v0.4.0, so this feedback helps a lot.

nununoisy commented 1 year ago

Should be fixed in v0.4.0. Let me know if you have any other improvements that could be made.

defensem3ch commented 1 year ago

hmm I'm not seeing the difference here. my noise crashes are still happening in the reverse direction