The VideoBuilder struct is pretty ugly and very non-idiomatic in its current state - it'd be great if it was rewritten to be a bit more maintainable and allow for some extra features.
[x] Refactor into a multi-file module
[x] Refactor planarize_video_data() to be a standalone function outside of the VideoBuilder impl
[x] Remove the vb_unwrap() calls or replace them with a macro
[x] Take a RendererOptions struct in VideoBuilder::new() to avoid long, ugly initialization calls
[x] If possible, replace explicit swscalers with FFmpeg filter chains to allow for some extra render features later
[x] Add support for containers other than MPEG-4, e.g. Matroska (see comment in #4)
nununoisy
commented
1 year ago
The
VideoBuilderstruct is pretty ugly and very non-idiomatic in its current state - it'd be great if it was rewritten to be a bit more maintainable and allow for some extra features.planarize_video_data()to be a standalone function outside of theVideoBuilderimplvb_unwrap()calls or replace them with a macroRendererOptionsstruct inVideoBuilder::new()to avoid long, ugly initialization calls