search

nunux-keeper / keeper-docker

Self-hosted Nunux Keeper with Docker
GNU General Public License v3.0
60 stars 5 forks source link

Bookmarklet seems to point to public keycloak instance not to local #7

Open zoernert opened 4 years ago

zoernert commented 4 years ago

Looking at the resulting JS Code at: https://keep.corrently.cloud/keeper/bookmarklet

it has:

<script src="https://login.nunux.org/auth/js/keycloak.js" type="text/javascript"></script>

I assume it should be:

<script src="https://keep.corrently.cloud/auth/js/keycloak.js" type="text/javascript"></script>

I think the code comes directly from the source and is not get customized during a make deploy based on .env settings.

ncarlier commented 4 years ago

You right! It's hard coded here: https://github.com/nunux-keeper/keeper-web-app/blob/master/public/index.html#L20 It's no big deal as long as you we are using the same Keycloak version. I should replace this by a template variable.

ncarlier commented 4 years ago

I just fixed the webapp. Can you pull a fresh keeper-web-app image and retry?

zoernert commented 4 years ago

I was not able to test as the Bookmarklet does now not honor the K_REALM Url which causes a redirect to the https://keep.corrently.cloud/keeper/keycloak.json => Auth_Server_URL and this does not contain the Servername (see previous issue)

ncarlier commented 4 years ago

What's the value of K_REALM ?

zoernert commented 4 years ago

K_REALM="https://keep.corrently.cloud/keeper"

In my Bookmarklet

ncarlier commented 4 years ago

It's correct... so I don't really understand the pb you have. Bookmarklet is not working as expected?