nuodb / migration-tools

Migration tools for NuoDB
http://nuodb.github.com/migration-tools/
BSD 3-Clause "New" or "Revised" License
27 stars 10 forks source link

Windows .bat file does not handle paths with spaces properly. #12

Closed rbuck closed 11 years ago

rbuck commented 11 years ago

A customer commented that if JAVA_HOME were set to a path in Program Files, that when you execute the .bat file they get an error saying that "Files\JRE\Java7"" was unexpected at this time". Note well, sets of double-double quotes in the string, causing the space between Program and Files to not be quoted.

kmoorthyd commented 11 years ago

Bob, Can we check what version of windows they have and probably get an echo of the JAVA_HOME variable? I tried this on my windows7 and did not see any issues.

D:\work\projects\nuodb\migration-tools\assembly\target\nuodb-migrator\bin>echo %JAVA_HOME% C:\Program Files\Java\jre7

D:\work\projects\nuodb\migration-tools\assembly\target\nuodb-migrator\bin>nuodb-migrator schema --source.driver=com.mysql.jdbc.Driver --source.url=jdbc:mysql://localhost:3306/nuodbtest --source.catalog=nuodbtest --source.username=root --output.path=dump.sql

D:\work\projects\nuodb\migration-tools\assembly\target\nuodb-migrator\bin>

Thanks, Moorthy.

plothridge commented 11 years ago

Bob, Please confirm whether this issue may be closed. -Thanks

rbuck commented 11 years ago

I tested on Windows and inspected the recent commit (%$... vs %...) and though the commit will certainly help, my gut feeling this was operator error. Closing.