search

nuodb / migration-tools

Migration tools for NuoDB
http://nuodb.github.com/migration-tools/
BSD 3-Clause "New" or "Revised" License
27 stars 10 forks source link

Mig 178 - NuoDB to NuoDB migration generated column fix #68

Closed sampada70 closed 1 year ago

adriansuarez commented 1 year ago

@sde70: As a general comment, can you add a summary of what the change is trying to accomplish so that we have a high level understanding when reviewing the code? I was only able to review this by commenting on code style and spotting Java issues. I have no idea if the logic is correct.

adriansuarez commented 1 year ago

Is the target for this PR correct and Is this the full changeset? I see the following at the top of the PR:

@sde70 wants to merge 2 commits into nuodb:sde70/MIG-178 from sde70:MIG-178---fixed

Both of those are personal branches. I'm assuming you want the PR to target the master branch.

sampada70 commented 1 year ago

Is the target for this PR correct and Is this the full changeset? I see the following at the top of the PR:

@sde70 wants to merge 2 commits into nuodb:sde70/MIG-178 from sde70:MIG-178---fixed

Both of those are personal branches. I'm assuming you want the PR to target the master branch.

sampada70 commented 1 year ago

Closing the pull request, please refer to the updated branch : https://github.com/nuodb/migration-tools/tree/sde70/MIG-178