Closed eresende-nuodb closed 1 year ago
I mistakenly used the wrong field to add reviewers. As soon I have full approval, I will then merge. Thanks.
It should not be necessary for CircleCI to explicitly support TestNG.
The Maven Surefire Plugin supports TestNG. It should just be a matter of configuring pom.xml so that the tests are discovered and run in the test
phase, which is executed as part of mvn install
. See the Surefire Plugin doc on Using TestNG.
@adriansuarez Thanks for the hint. If it is ok for everyone, I will merge this PR as it is now and check the testing afterwards.
@adriansuarez Thanks for the hint. If it is ok for everyone, I will merge this PR as it is now and check the testing afterwards.
@eresende-nuodb: I took a look at the build log, and the tests did run. You just have to make a minor change to publish the test results correctly and you'll be all set. See my other comment.
This PR adds integration to CircleCI platform.
Unfortunately I wasn't able to add the tests since this project uses "testng" test framework which CircleCI does not support. Not sure if there's a workaround this limitation.