search

nuodb / migration-tools

Migration tools for NuoDB
http://nuodb.github.com/migration-tools/
BSD 3-Clause "New" or "Revised" License
27 stars 10 forks source link

Circleci project setup #78

Closed eresende-nuodb closed 1 year ago

eresende-nuodb commented 1 year ago

This PR adds integration to CircleCI platform.

Unfortunately I wasn't able to add the tests since this project uses "testng" test framework which CircleCI does not support. Not sure if there's a workaround this limitation.

eresende-nuodb commented 1 year ago

I mistakenly used the wrong field to add reviewers. As soon I have full approval, I will then merge. Thanks.

adriansuarez commented 1 year ago

It should not be necessary for CircleCI to explicitly support TestNG.

The Maven Surefire Plugin supports TestNG. It should just be a matter of configuring pom.xml so that the tests are discovered and run in the test phase, which is executed as part of mvn install. See the Surefire Plugin doc on Using TestNG.

eresende-nuodb commented 1 year ago

@adriansuarez Thanks for the hint. If it is ok for everyone, I will merge this PR as it is now and check the testing afterwards.

adriansuarez commented 1 year ago

@adriansuarez Thanks for the hint. If it is ok for everyone, I will merge this PR as it is now and check the testing afterwards.

@eresende-nuodb: I took a look at the build log, and the tests did run. You just have to make a minor change to publish the test results correctly and you'll be all set. See my other comment.