nurdism / neko

A self hosted virtual browser (rabb.it clone) that runs in docker.
Apache License 2.0
2.03k stars 185 forks source link

[BUG] Can't Type as Client in Firefox #26

Closed CorySanin closed 4 years ago

CorySanin commented 4 years ago

Describe the bug Perhaps there is something I'm missing, but I'm unable to type anything into the browser through the client running inside of Firefox. Client works fine in Chrome.

To Reproduce Steps to reproduce the behavior:

  1. Start docker container (nurdism/neko:firefox)
  2. Open the web client within Firefox
  3. Take control of the remote
  4. Attempt to type anything

Expected behavior Can type into the remote browser when control is obtained

Screenshots N/A

Desktop (please complete the following information):

Additional context I tried using Chrome on Windows and it worked as expected. Still using Firefox within the container

Client Log: I see this a bunch:

TypeError: "navigator.clipboard.readText is not a function"

Server Log: N/A

Rami-Pastrami commented 4 years ago

had a similar issue through a nginx reverse proxy only. It went away randomly though

CorySanin commented 4 years ago

That might be the issue then. I'm also using nginx as a reverse proxy.

nurdism commented 4 years ago

This might be due to firefox and needing https for clipboard access, I need to do some testing on firefox with https.

CorySanin commented 4 years ago

Do you think that if I use Chrome in the container and Firefox for the client that my setup would work?

nurdism commented 4 years ago

well navigator.clipboard.readText is a client side issue, the server should be working.

nurdism commented 4 years ago

so can confirm, does not work on ff, chrome works just fine. going to look into alternative for clipboard api on ff

https://i.imgur.com/FnkGCzw.png

nurdism commented 4 years ago

I've updated the docker container with a potential fix for this, please update and check it out. Reopen if this still an issue for you

CorySanin commented 4 years ago

Thanks, that works!