nurdism / neko

A self hosted virtual browser (rabb.it clone) that runs in docker.
Apache License 2.0
2.03k stars 185 forks source link

Change the login page to use "Display Name" instead of "Username" #55

Closed hendersonreed closed 4 years ago

hendersonreed commented 4 years ago

Purpose

This is to make the UI a little more intuitive to new users. At the moment, the usage of the word "username" implies that there are static accounts that persist between sessions. By using "display name" instead, it is a little more apparent that "display name" is just what your name will be to other users.

Testing Performed

Uh, I couldn't find any info on how to test this change, but my belief is that this is the correct place to change the page. If a maintainer/someone familiar with how to test this project could verify that this works, I would be really appreciative. I can also test it, if some info is shared to me on how - I'd close the PR and open a new one after testing.

nurdism commented 4 years ago

lgtm