search

nurdism / neko

A self hosted virtual browser (rabb.it clone) that runs in docker.
Apache License 2.0
2.03k stars 185 forks source link

RTCIceServer frontend bug fix #65

Closed m1k1o closed 4 years ago

m1k1o commented 4 years ago

This bug caused following error: image

I'm assuming, servers should be added only if lite is active. Otherwise they are undefinded. So likely it's just typo, it should have been lite === true instead of lite !== true. But no point of createing double new RTCPeerConnection() anyhow. It breaks current development stack.

nurdism commented 4 years ago

if lite !== true is correct, lite meaning using ICELite witch requires no STUN or TURN servers. If it's throwing an error then there is something else going on.

m1k1o commented 4 years ago

I see... Maybe the case was, I was using backend from docker image and frontend from latest commit and they are not compatible.