search

nurdism / neko

A self hosted virtual browser (rabb.it clone) that runs in docker.
Apache License 2.0
2.03k stars 185 forks source link

[FEATURE] i18n keyboard layouts #72

Closed m1k1o closed 4 years ago

m1k1o commented 4 years ago

Ony US (standard) layout is supported. It would be great, to choose cusom layout or even (if possible) get this information from host browser.

When I am using any other layout, it does not bind correclty. I am not expecting it, to bind correctly that chosen layout (since it is not implemented yet) but not even US layout works, when I have any different on my host computer.

E.G. Slovakian keyboard bind correctly except key - is switched with / (and ofc this is quertz, so z is switched with y what is expected). On german keyboard layout are more keys (5+) switched. So only if i switch my host to US keyboard is neko usable.

Since i18n was introduced, this would be also great feature.

nurdism commented 4 years ago

this would need a rewrite on how the keybord input is handled on both server and client

nurdism commented 4 years ago

maybe handle it like guacamole https://github.com/apache/guacamole-client/blob/master/guacamole-common-js/src/main/webapp/modules/Keyboard.js

m1k1o commented 4 years ago

WIP https://github.com/m1k1o/neko/commit/aa1fedcb24a85ba9eadd79031bbc25f498a4fdf3

m1k1o commented 4 years ago

Implemented handling from guacamole. https://github.com/nurdism/neko/compare/ca0b5b2d354c938859680f93caac1b5c1279b2ff...m1k1o:5cf9c2931922e5912fee06c0661f5dcf0726c7df