nurdism / neko

A self hosted virtual browser (rabb.it clone) that runs in docker.
Apache License 2.0
2.03k stars 186 forks source link

components/video.vue: fix keyup-on-blur code #79

Closed barzamin closed 4 years ago

barzamin commented 4 years ago

the code authored in 52ee7372765e272aad7cb52b9dceecf9d0145f55 (probably) worked in the browser due to string to numeric type autoconversion but didn't typecheck during container build.

namely, Object.keys(this.activeKeys) will always return a string[]; however, we need keys to be numbers for the sendData() call to typecheck.

this replaces the untyped object holding active keys with a Set<number>, which is closer to intent anyway

fixes #78

nurdism commented 4 years ago

lgtm