nurikk / zigbee2mqtt-frontend

Zigbee2MQTT frontend
https://www.zigbee2mqtt.io/
GNU General Public License v3.0
250 stars 181 forks source link

Decide on normal-case or all-upper-case for vendor names #1930

Open holgerschurig opened 6 months ago

holgerschurig commented 6 months ago

Is your feature request related to a problem? Please describe.

Today I searched if Z2M supported some Avatto relay device. Unfortunately, this didn't seem the case:

Only later did I notice that this Vendor is entered twice, the other time with lots of devices, including the relay one:

I also noticed that this is the case with "MOES" and "Moes", and probably other. So we have several vendors that are twice in the database, with varying capitalizations.

Describe the solution you'd like

I would suggest that if one enters a new device to the database, the vendor is first compared case-insensitive. And if a vendor is found, the vendor name from the database, not the application, is used. That would someone provide a device entry for "AVATTO" have his vendor rewritten automatically to the already-existing "AVATTO".

pano9000 commented 6 months ago

Hi,

This is not an issue with the zigbee2mqtt-frontend project, but the docs here: https://github.com/search?q=repo%3AKoenkk%2Fzigbee2mqtt.io%20avatto&type=code