search

nurkiewicz / spring-data-jdbc-repository

Spring Data JDBC generic DAO implementation
275 stars 151 forks source link

Support for SQL Server (2008 / 2012) #2

Closed thomasdarimont closed 11 years ago

thomasdarimont commented 11 years ago

Hello Tomasz,

I just read your article on dzone: http://architects.dzone.com/articles/spring-data-jdbc-generic-dao ... and I thought I could help.

I tested your framework against sqlserver 2008 / 2012 and added the missing sql server support to make all unit-tests pass.

So feel free to pull my master-branch if you want to :)

Best regards, Tom

nurkiewicz commented 11 years ago

Awesome, I really appreciate your work! I love the fact that you implemented both 2008 and 2012 dialects. I'll review your pull request (checkstyle is complaining on Travis) ASAP.

Thank you again, great job!

nurkiewicz commented 11 years ago

Thank you for your contribution! Your pull request is now merged and version 0.2 released.

I only downgraded jTDS driver to 1.2.7 so that it builds on Java 6. It would be great if you could make sure it still passes all tests (too bad MS SQL is not available on Travis CI).

For a moment I considered splitting MS SQL Server tests even further so that a separate hierarchy runs against 2008 and a separate one against 2012. This way one could test both dialects in one build. But let's leave that for later.