search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
181 stars 14 forks source link

Certain characters are avoided in the character palette #103

Closed Viza74 closed 5 years ago

Viza74 commented 5 years ago

If I move with the wasd keys, there are certain charcters which are... avoided by the program. Eiither just skips over them, or literaly goes around them.

I made a video: https://drive.google.com/file/d/1SpoJN3Q-s0P5Tt4G8PysX5zN7Hu7klZV/view?usp=sharing

In the first part of the video, I just move left and right with the a and d keys. There are chars which skipped. The keypress seems to be swallowed - so I press the key, nothing happens, then press the key again, and the selection jumps over one character. In the second half, I move up and down with the w and s keys, and the selection just goes around the problematic character without me touching any of the a or d keys.

I can't repro yet unfortunately, but this is not the first occurence.

nurpax commented 5 years ago

Any chance you pressed 'r' to rotate the current char? It could be a bug related to the new char rotation code or a weird side-effect of how I implemented it.

nurpax commented 5 years ago

Yeah I just reproed it.. Thanks for reporting it, I wasn't aware of this.

I can easily trigger it by pressing 'r' on some char that can be rotated and then moving around with wasd.

This is a really funny bug. :)

nurpax commented 5 years ago

Oh, it doesn't even need 'r'. Repros from clean state without any rotation business. WTF

Viza74 commented 5 years ago

Hmm, it is nice to have a repro, but I'm reasonably sure that I did not rotated characters... There is a small chance that I did accidentally, but definitely not intentionally.

Viza74 commented 5 years ago

ohh, your comment just jumped in front of mine :)

Esshahn commented 5 years ago

great work guys!