nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
181 stars 14 forks source link

show cursor outline within the selected char, not ouside of it #114

Open Esshahn opened 5 years ago

Esshahn commented 5 years ago

This took me a while to realize and I was pretty confused.

Look at this:

screenshot 2018-09-06 um 18 52 26

I thought, "hey, there's a thin black line on the right to the cursor!" Then I switched one character to the right and

screenshot 2018-09-06 um 18 52 33

"Why the heck is the thin line now twice as thick???"

This outside border is quite distracting I think.

Solutions:

or

Option 2 would be my favorite as there's only so few C64 colors that slight color changes do not affect the workflow, whereas a border is very close to the char set graphics and kinda gets in the way.

nurpax commented 5 years ago

Option #1 is IMO not good because it will then overlap with the PETSCII char and this would be equally distracting as the mouse pointer on top of the char cursor.

Maybe an opacity 0.1 or so white or black (depending on char color/bg color) rectangle on top of the character without any border?

Esshahn commented 5 years ago

sounds good