search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
181 stars 14 forks source link

Char rotation not working in all cases #117

Closed Esshahn closed 5 years ago

Esshahn commented 5 years ago

For most of the time, character rotation is nothing less than amazing. Fantastic work here Janne, loving it!

I noticed that the normal diagonals

screenshot 2018-09-06 um 22 26 48

do not rotate with their inverse versions

screenshot 2018-09-06 um 22 26 56

Is that doable?

nurpax commented 5 years ago

Only bit exact transformations are considered as a match when finding the rotated screencode. I imagine the above is not exactly a rotate version of the other, so it can't find a match. So if we wanted this, would need to add some sort of fuzzy logic to finding the match. Seems like that'd open a can of worms in terms of heuristics.

Esshahn commented 5 years ago

You are right! I never noticed the difference, the lower ones do have a pixel less.