error when renaming screens starting a number

nurpax / petmate

PETSCII editor with Electron/React/Redux

MIT License

181 stars 14 forks source link

error when renaming screens starting a number #124

Closed Esshahn closed 5 years ago

Esshahn commented 5 years ago

Reproduce

click on a thumbnail name to edit it
enter a number
press return

Result

screenshot 2018-11-22 um 15 02 41

nurpax commented 5 years ago

We decided in an earlier issue that we should only allow screen names that are not valid assembler/C symbol names.

Maybe that’s too strict and we should just let .asm exported petscii fail to compile.

I guess I’d slightly prefer to just let compilation break. Doesn’t seem like a big deal — programmers should be able to figure it out if they look at the exported file.