search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
179 stars 14 forks source link

Renaming bug #128

Closed Esshahn closed 5 years ago

Esshahn commented 5 years ago

I've enountered a strange renaming issue. It can be seen by closely watching the attached video.

What happens: At 09 seconds in the video I rename a thumb and instead of renaming that thumb, the previous one in the list gets renamed.

Not sure how to reproduce that yet. Latest 0.6 version rename-bug.mov.zip

Esshahn commented 5 years ago

Ok I got it reproducable. Petmate renames the file that is active (white border around thumb), regardless of which thumb's name is renamed.

bildschirmfoto 2019-01-14 um 18 20 18

When I rename the right thumb, the left thumb gets renamed.

nurpax commented 5 years ago

Whoah. :) I I probably broke this in my TypeScript porting. Shouldn’t be too difficult to fix.