custom canvas: big numbers crash petmate

nurpax / petmate

PETSCII editor with Electron/React/Redux

MIT License

179 stars 14 forks source link

custom canvas: big numbers crash petmate #137

Closed Esshahn closed 5 years ago

Esshahn commented 5 years ago

Petmate can be crashed if numbers for the canvas are too big, e.g. setting

99999x232323

Recommendations:

do not accept numbers too big
convert too big numbers to the highest allowed one automatically

nurpax commented 5 years ago

Thanks for reporting this! Someone had to have the courage to try what happens. I set the max to 1024x1024 now. Even that feels a bit like zooming into a fractal..

nurpax commented 5 years ago

The input form just clamps the values. Doesn't give any kind of an error. Pretty sure that's ideal. Error messages are always kind of scary.