search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
179 stars 14 forks source link

Added seq export format #149

Closed manuelvio closed 5 years ago

manuelvio commented 5 years ago

Recently I was asked to create a PETSCII logo for a bbs and I needed to save my file in seq format. Due to lack of support for this format in petmate I had to save my file in an intermediate .c format and open it in Marq's PETSCII editor in order to get a seq export. Luckily enough, sources for seq export are available, so I decided to integrate them into petmate as an exercise (and because I'm a bit lazy and I don't want to jump from an editor to another :) ) I've noticed that issue #99 was closed due to the lack of specifications, I don't know if this particular implementation meets some official standards (if any), but I can say that files generated with it can be used in bbs.

nurpax commented 5 years ago

Very cool!!

A funny coincidence. I got another SEQ export for Petmate last night. This was in an email so not visible here.

But yours is slightly simpler and already in a PR.

I added some code review comments. Also can you clean up the git commits with interactive rebase? There’s some extra merging in the PR but I think this could ne just one commit if rebased against head.

Thanks!

manuelvio commented 5 years ago

👍👍👍No probs with about cleaning it up, I'll rebase it and re-roll the PR. Be aware that I have no experience with Typescript, so style here could be, well, weird.

manuelvio commented 5 years ago

Closing in order to open a tidier PR