nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
179 stars 14 forks source link

seq "Optimize sequence" option breaks the image #159

Closed nurpax closed 4 years ago

nurpax commented 5 years ago

This is what I get when I export with "Optimize sequence" and re-import.

@manuelvio, any ideas?

image

manuelvio commented 5 years ago

Poor Dave, nope, I have to re-check what causes this issue. At first sight it could be an odd use of blanks in original screen, since they're the ones being erased.

manuelvio commented 5 years ago

Ok, I got it. Blanks in the middle of the screen were reinserted without checking current reverse status, thus becoming reversed blanks in some lines, namely where previous char was reversed.

Inner blank blocks should be inserted with a proper 0x92 code where needed, as in the screen below:

petmate_enjoy

nurpax commented 4 years ago

fixed by @manuelvio, see #160