search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
179 stars 14 forks source link

Program active for 6 hours, then UNDO/SAVE features no longer respond to keybaord shortcuts #164

Open wbochar opened 4 years ago

wbochar commented 4 years ago

I leave the application open for long periods of time, to review what I am working on and do minor edits over the course of the day. At some point (around the 6hr mark) the shortcut keys for UNDO and SAVE seem to stop working or work intermittently.

I've checked other applications that are also running and they do not have this issue.

Windows 10 / 64bit 32GB Ram

PS: Thanks for a great piece of software, very handy!

nurpax commented 4 years ago

I'm assuming this is using the latest Petmate version?

Undo and Save are accelerator keys coming straight from menu items.. so it's a little surprising that they'd stop working altogether.

I haven't ever used Petmate for so long so I certainly can't claim that something funny wouldn't be going on after a long time use.

The undo stack is unbounded in Petmate. I wonder if that'd grow to unmanageable size in a long session? This feels really unlikely to me though.. still seems kind of a trivial amount of data by modern standards.

wbochar commented 4 years ago

Latest Version, with about 20 pages open. I tend to move back and forth between pages, making small edits (after the initial batch of drawing is done). I don't know about the exact time it happens, but every so often I'll close it down and restart the application and the keyboard shortcuts work. I do quite a bit of importing and exporting. I really put the application through its paces. I'll try to create a scenario on another machine and see if I can run a test case on it.

nurpax commented 4 years ago

There have been bugs in Petmate where shortcuts stop working when the app loses/gains focus. But usually these have been other shortcuts, not save or undo. I thought I fixed these for good in Petmate 0.7.1 (please check https://github.com/nurpax/petmate/issues/161 if that rings a bell), but maybe I still didn't somehow nail this one.

wbochar commented 4 years ago

Ehh I was doing a lot brush stuff and that happened a few times, but I was thinking it was between my head and the keyboard not the application. Interesting.