search

nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
185 stars 14 forks source link

cleanup boilerplate project (removing unstable parts, typeflow, etc.) #24

Closed nurpax closed 5 years ago

nurpax commented 6 years ago

https://github.com/pbarbiero/enhanced-electron-react-boilerplate

at least once my upgrade PR goes in

Esshahn commented 6 years ago

probably too far into the process to make that change, right? Close?

nurpax commented 6 years ago

will do this at some point. the current boilerplate is a pita to work with

Esshahn commented 6 years ago

will it get harder with every line of code added? Then I'd recommend putting it in the current release and be done with it ;)

nurpax commented 6 years ago

no, most code will drop in cleanly 1:1 into the new project structure. just need some git gymnastics to retain version history

nurpax commented 6 years ago

OK so I tried doing this but... it got hairy.

I think I'll just clean up some odd parts of the current boilerplate and call it a day. I'm especially unhappy with HOT loading because it breaks things more than helps.

nurpax commented 5 years ago

This was done for 0.5.0 and boy did I get rid of a lot of cruft.