nurpax / petmate

PETSCII editor with Electron/React/Redux
MIT License
181 stars 14 forks source link

Closing window makes Petmate unusable (Mac) #96

Closed Esshahn closed 5 years ago

Esshahn commented 6 years ago

There are some related issues tracked already, but maybe this is a quick fix:

Problem:

Suggested fixes: a) do not allow to close the main window b) when closing the main window, quit the app completely c) allow to open a new window when window was closed (auto-open with file operations, too)

All three of them would work I guess, and I've seen all of these in other apps as solutions. From UX perspective, I'd go for "b", as this will likely follow the user's initial intention when closing the window.

Viza74 commented 6 years ago

Duplicate of #47 and maybe #36 ?

Esshahn commented 5 years ago

closing as petmate now quits

nurpax commented 5 years ago

it does? i must’ve fixed it by accidentally:)

or maybe it crashes and then exits.

nurpax commented 5 years ago

Yeah, it's indeed fixed and the code handling this makes sense:

app.on('window-all-closed', () => {
    app.quit();
});