search

nurpax / snap-examples

Example code web apps using the Snap Framework
20 stars 3 forks source link

Updated cabal upper bounds #2

Closed alexanderkjeldaas closed 11 years ago

alexanderkjeldaas commented 11 years ago

Hi, I read your blog post and in trying out the code I had to update some upper bounds.

nurpax commented 11 years ago

@alexanderkjeldaas thanks! I made the same changes locally last weekend but didn't push them as I hit yet another dependency problem that caused a build break for me. When you built with these changes, you didn't hit any problems with snap-0.11.1?

I had a problem with digestive-functors-heist (which is a dependency of snap-extras), see https://github.com/jaspervdj/digestive-functors/pull/58. Thus I haven't pushed my changes yet as I thought it wasn't building even with these upgrades. Maybe I had too strict dependency constraints.

Thanks, I'll check review this in more detail today/tomorrow!

alexanderkjeldaas commented 11 years ago

No I haven't tested this. I am just trying to get a coherent build with the latest packages and ghc 7.6.2. I am just starting develpment (in both yesod and snap actually).

On Tue, Feb 19, 2013 at 9:32 AM, Janne Hellsten notifications@github.comwrote:

@alexanderkjeldaas https://github.com/alexanderkjeldaas thanks! I made the same changes locally last weekend but didn't push them as I hit yet another dependency problem that caused a build break for me. When you built with these changes, you didn't hit any problems with snap-0.11.1?

I had a problem with digestive-functors-heist (which is a dependency of snap-extras), see jaspervdj/digestive-functors#58https://github.com/jaspervdj/digestive-functors/issues/58. Thus I haven't pushed my changes yet as I thought it wasn't building even with these upgrades. Maybe I had too strict dependency constraints.

Thanks, I'll check review this in more detail today/tomorrow!

— Reply to this email directly or view it on GitHubhttps://github.com/nurpax/snap-examples/pull/2#issuecomment-13761891.

nurpax commented 11 years ago

@alexanderkjeldaas When I try to build with your changes, it doesn't build on my ghc 7.4.2:

Registering snap-server-0.9.3.1...
cabal: Error: some packages failed to install:
angularjs-todo-0.1 depends on errors-1.3.1 which failed to install.
errors-1.3.1 failed during the building phase. The exception was:
ExitFailure 1
heist-0.10.2.1 depends on errors-1.3.1 which failed to install.
snap-0.10.0.1 depends on errors-1.3.1 which failed to install.
snap-extras-0.3 depends on errors-1.3.1 which failed to install.
snaplet-sqlite-simple-0.4.1 depends on errors-1.3.1 which failed to install.

(this is with cabal-dev install, all libraries from scratch).

OTOH, if constrain snap lower bound to 0.11 then it works. I guess I'll have to restrict snap to >= 0.11 instead of allowing lower versions. I was about to switch to 0.11.1 anyway, so I'll merge your PR and fix the snap constraint in a separate change.

Thanks for the patch!