search

nursoda / twofactor_email

Nextcloud 2FA Provider that uses e-mail as transport
GNU Affero General Public License v3.0
24 stars 11 forks source link

Should be selectable upon initial login when 2FA is enforced #35

Open nursoda opened 4 years ago

nursoda commented 4 years ago

If you have 2FA enforced on NC and create a new user, that user has to set up 2FA upon 1st login. TOTP and U2F are available upon 1st login, twofactor_email is not but should be.

gumaol commented 4 years ago

I logged in as new user and I see the button "enable", but it did not function! No 2FA email would be send!

ghost commented 4 years ago

I only see totp

AndyXheli commented 3 years ago

dupe of #83 ?

nursoda commented 3 years ago

I think they could be merged, but I see slightly different scopes:

THIS issue focuses on the fact that twofactoremail may only be chosen AFTER 1st login but not on initial account setup (while other twofactor Apps ARE available. So IF an e-mail-address is present in the user account AND twofactor_email is installed, new users should be able to choose twofactor_email also.

83 asks to even automatically enable and use twofactor_email per default.

tpokorra commented 3 years ago

see this commit for TOTP that introduced "Setup at Login": https://github.com/nextcloud/twofactor_totp/commit/165b0f09e9562c2f4c4f27f6c25ebe941f99533e also see the search for LoginSetup: https://github.com/nextcloud/twofactor_totp/search?q=LoginSetup

AndyXheli commented 2 years ago

This would be awesome to have

StefanoWoerner commented 2 years ago

Hi, what is the progress on this? Are there any blockers that need solving? I'd like to help.

nursoda commented 2 years ago

No blockers from outside the app. Just nobody implementing it. I'm not a software developer, I just try my best to maintain this app by formulating requirements and reviewing PRs. There was a PR that I reviewed but the author withdrew it. If you can help here or know someone who could and who cares, please review the old PR or establish contact.

thomas-mc-work commented 1 year ago

This is the mentioned PR: https://github.com/nursoda/twofactor_email/pull/357

Can't please someone have a look on it?