search

nurupo / ProjectTox-Qt-GUI

A cross-platform front end for ProjectTox Core library, written in C++11 with use of Qt5
GNU General Public License v3.0
341 stars 116 forks source link

Sounds #112

Open Schlumpf opened 10 years ago

Schlumpf commented 10 years ago

We have sounds in our repo for a long time, but nobody used them, till now.

I implemented the sounds as soundpacks (themes), so the sounds from our sound directory are a "default pack" and have to moved into the soundpack directory (by installer?): QStandardPaths::writableLocation(QStandardPaths::ConfigLocation) + '/' + AppInfo::name + "/sounds"

I did the pack handling different from the smileypacks, if it's better in this way, I'll change the smileypack, too.

nurupo commented 10 years ago

I remember some Google Summer of Code student messaging me on IRC saying that they implemented sound notifications, but I never got a PR from them, huh

nurupo commented 10 years ago

by installer?

Yes, by installer, when we get one sorted out, which is a whole different issue.

Also, we need to do something about coding style, you are completely ignoring mine : )

nurupo commented 10 years ago

Anyway, it will take me some time to go over this and messages pull requests since it seems that I will be very busy for the next two weeks.