New message view

[Schlumpf]

Here comes the new message view.

Features:

• Faster chat view widget (QGraphicsView based)
• Search for text
• Smiley support
• Full text selecting and copying
• Sending and displaying typing notifications
• Marker line on last seen message
• Custom time stamp format

Fixes:

• 59 Copy selected text with smileys from message label doesn't work

• 62 Reimplement Message Display widget

• 64 Custom time stamp format

• 99 Can't highlight more than 1 line at once

PS: This replaces the old push request #110 .

[nurupo]

Found a bug. To reproduce:

1. Add a friend. You will get "id is now known as x" message when the friend comes online.
2. Send a message with "now" in it.
3. Toggle the search with ctrl+f.
4. Search for "now" with "Regular messages only" untoggled.
5. You will see it highlighting "now" in the name change message ("id is now k now n as x") and in your sent message.
6. Now toggle "Regular messages only".
7. It still highlights words from the name change message, and even steps through them with arrow buttons.

Desired behavior at (7) is that "now" in namechange message are not highlighted and don't get stepped through.

Also, why not having three togglable buttons for name, message and even message searches, as Quassel does? There is not that much room to put them, but it gives more control over the search.

[Schlumpf]

Bug fixed. Because we haven't that much space I selected the most important options. Quassel's search checkbox isn't very useful, hide the search bar and you have the same effect. And I thought, that searching nicks isn't important. Normal chats have 2 contacts... Maybe filtering in logs will be more interesting here.

[nurupo]

Quassel's search checkbox isn't very useful, hide the search bar and you have the same effect.

Not sure what you mean. I was talking about the four checkboxes Quassel has on its search widget.

Because we haven't that much space I selected the most important options.

The current default window size is quite minimal, we could increased it, or we could remove the text like "Regular messages only" from the buttons and use icons instead, though that's a bit cryptic, I like to know what a button does without a need to hover over it...

And I thought, that searching nicks isn't important. Normal chats have 2 contacts...

But there will be groupchats.

[nurupo]

Are those // TODO MKO ... comments belong to you?

[nurupo]

Also, some of files miss the license notice.

[Schlumpf]

ChatScene::CutoffMode doesn't seem to be used anywhere, should we keep it or remove it? What was it originally used for anyway?

I'll remove that. It described, how Quassel cuts long nick names. Maybe the mockup guy from #12 could make a proposal how to do in Tox.

Are those // TODO MKO ... comments belong to you?

Yes ;)

[nurupo]

Maybe the mockup guy from #12 could make a proposal how to do in Tox.

Will ask him how would he cut off too long nicknames. It makes more sense to me to do CutoffRight, though there are some languages that are written in right to left direction, maybe that would make more sense to their users (though it would make even more sense to mirror the whole message display in that case, and i don't think we are going that far as implementing that, heh).

[nurupo]

I see you also used a timer for typing notifications, nice. It's kind of an obvious thing, but apparently some people miss that, considering one conversation on an irc channel.

Btw, I saw you pinging me on the irc the other day, feel free to email me if I'm afk in irc.

[nurupo]

I selected a smiley :(, copied it and pasted into the input widget, but it pasted " :" instead.

If I select the :( smiley and a space after it, then it pastes " :(" (with a space in the beginning).

[nurupo]

I didn't really read all the code, though I don't see why I shouldn't merge it and read&fix afterwards as I go, not to mention that it works well and I didn't notice any outstanding bugs.

Thanks for the work, hopefully that smiley bug would get fixed : )

[aviau]

Wohoo this got merged =) Good job @Schlumpf

[lance0]

Great work.

[nurupo]

Yep, smileys seem to be a bit buggy, will make a separate issue.