Spellchecking #100

[msteinbeck]

This is a first version of spell checking (only works on linux and maybe mac, since i have no windows machine available to compile hunspell as static lib). It also provides the feature to replace a misspelled word with a suggested word. The spell checking itself can be used on any QTextDocument.

I had some trouble to add a dictionary to the rcc file therefore i used a static path to "/usr/share/hunspell/en_US.aff" and "/usr/share/hunspell/en_US.dic". Furthermore I am not sure whether we should bundle some dictionaries or use the system one. The second option causes some extra work for windows clients, so I would recommend to bundle the common languages

[nurupo]

Could you add the hunspell library to the .travis.yml file so that Travis-CI could build the PR?

[nurupo]

Tested with hunspell on Windows. It works, but requires some improvements. For example:

• The suggestion words are added at the very bottom of the context menu, with the best suggestion at the very bottom, going up to the worst suggestion.
• In order to check a word, user should have so called "I-beam" cursor at the word, you can't just right-click any word.to check.
• It marks words that you currently didn't finish typing as incorrect.

I think it's a bit fresh for merging into the master as, how you name it "first version".

Making suggestion show at the top of the context menu popup in reverse order of what it is now, allowing to right-click on a word where we don't have the I-beam cursor blinking (well, that one actually can be added later) and adapting the code from the link mentioned in https://github.com/nurupo/ProjectTox-Qt-GUI/issues/100#issuecomment-35144762 instead of writing own from the bottom up should make it merge-able. Not sure if you are going to work on it or not, you didn't reply to any comments. I could move your commit to another branch, make improvements myself and then merge with master, though I have other PRs to take care of first. I bet @Schlumpf is angry on me for not doing anything with his PRs yet : )

[Schlumpf]

@nurupo :( What's wrong with my PRs?

[msteinbeck]

Of course I will continue working on this ticket. The reason that i didn't replay your comments were simply that I visited a friend over the weekend. Could you send me, or simply add a pull request for the windows lib of hunspell?

I will fix the suggestions list asap (maybe today). I also could add some dictionaries for common language to the repository.

[msteinbeck]

[...] Could you add the hunspell library to the .travis.yml file so that Travis-CI could build the PR? [...]

I'm not familiar with Travis-Cl. Do i have to simply wget the package and add the include path?

[ghost]

@retuxx You just do what you would've done using bash. I.e. :

before_install:
  - wget pack.tar.xz https://link.wot/pack.tar.xz > /dev/null
  - tar xJf pack.tar.xz > /dev/null
  - cd pack
  - ./configure  > /dev/null
  - make && make install  > /dev/null

[ghost]

Check if the libhunspell is in the right PATH

[msteinbeck]

Installing hunspell from apt should be the easiest way :)

[nurupo]

Could you send me, or simply add a pull request for the windows lib of hunspell?

That's a bit nasty -- creating a branch to send you a PR that will be added to the PR you are making to me that will end up back in one of my branches. Anyway, here it is a small patch https://github.com/retuxx/ProjectTox-Qt-GUI/pull/1, read the comment on it.

[msteinbeck]

I finished the spell checker. As far as I can see I fixed all your announcements. Nevertheless a dialog for setting up the preferred language is missing but depends on #116.

[nurupo]

I finished the spell checker. As far as I can see I fixed all your announcements.

Thanks : )

Nevertheless a dialog for setting up the preferred language is missing but depends on #116.

Could you explain how it depends on the new message display?

[msteinbeck]

I misread the the topic of this PR and thought it contains a new settings dialog