search

nurupo / ProjectTox-Qt-GUI

A cross-platform front end for ProjectTox Core library, written in C++11 with use of Qt5
GNU General Public License v3.0
343 stars 117 forks source link

Refactoring the UI classes with .ui files #53

Closed FrenchDilettante closed 11 years ago

FrenchDilettante commented 11 years ago

Hello,

I wanted to work on #12, but it's practically impossible do it in .cpp files... So, I was wondering if refactoring the dialogs to use qt designer (.ui) files would be something acceptable ? It makes the code cleaner and more readable IMO. Back to my point, using the designer makes UI integration (using CSS styling) waaaaay easier :)

I started this refactoring on a separate branch, it doesn't seem to be a job too difficult, is it something you would be interested in ? I created this pull request to have your opinion on it.

nurupo commented 11 years ago

I prefer writing UI in code. It's easier to see what properties were changed from their default values and comment on why you did some not so obvious change, which is very important when you try to figure out why X doesn't work, and I find it easier to understand how code works in general, since switching between the UI designer and code is a bit distracting, because of the change of context. We try to keep the UI code structure simple and organized, settings pages would be the best example of this, so most of the time you shouldn't have trouble visualize what it should look like, but I agree that UI editor is better at visualizing.

So, I was wondering if refactoring the dialogs to use qt designer (.ui) files would be something acceptable ?

Don't think so.

FrenchDilettante commented 11 years ago

OK, no problem. I'll figure out something else for #12.