search

nurupo / ProjectTox-Qt-GUI

A cross-platform front end for ProjectTox Core library, written in C++11 with use of Qt5
GNU General Public License v3.0
342 stars 116 forks source link

Smiley packs #58

Closed Schlumpf closed 11 years ago

Schlumpf commented 11 years ago

Here is the first implementation of smileypacks (https://github.com/nurupo/ProjectTox-Qt-GUI/issues/49).

I moved the smile/desimle functions the the new smileypack class. This class also contains functions to create a pack from a theme-file. New packs are located in the users settings directory. On my linux it's: ~/.config/Qt GUI for Tox/smileys.

The smileypack mechanism supports emoij. There are two build-in packs: the already existing default pack and a emoij pack. For systems, which don't supporting Unicode 6.1 (like WinXP), I included the "DejaVu Sans" font. If the user has selected a classic smiley pack, incoming emoij will converted to text and then to the smiley image from the pack.

I also wrote a new algorithm for the "smile" function. The existing function had a problem with "smileys in smileys". E.g. ]:) and :). Because of the :) came at first in the hash, the evil was translated to ] :). That's fixed now.

nurupo commented 11 years ago

I took a quick look and saw that in one case you change the whole message label's font to the DejaVu, when only emoji need to use that font. Ideally, there should be a font changing option added, so that user could set any font they would like and all messages would change their font to the specified one, which will conflict with setting DejaVu on the whole message label. You could just specify in CSS to make everything included in some tags use DejaVu font and apply those html-tags on emoji, so that message's text can be in whatever font and emoji will be in DejaVu.

nurupo commented 11 years ago

Those .h files, when we are using .hpp. You can change it in Qt Creator's settings. You can also set a text file with your license statement insert in settings and Qt Creator will add it to all newly created files automatically.

nurupo commented 11 years ago

Merged. Sorry for keeping you waiting :)

nurupo commented 11 years ago

Oh wow, you spelled emoji as emoij in so many different places.

nurupo commented 10 years ago

Why do you serialize the whole smiley pack into settings.ini when you could just store smiley pack name or path to the smiley pack instead, and simply reparse the smiley pack theme file? All info you are serializing is already in the smiley pack theme file.